[Webkit-unassigned] [Bug 55719] [Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55719


Oleg Romashin (:romaxa) <romaxa at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85029|                            |review?
               Flag|                            |




--- Comment #28 from Oleg Romashin (:romaxa) <romaxa at gmail.com>  2011-03-08 00:10:11 PST ---
Created an attachment (id=85029)
 --> (https://bugs.webkit.org/attachment.cgi?id=85029&action=review)
Qt Xlib includes conflict fix, Fixed include order, QTBUG-54

A bit hacky fix, against webkit style but according to 
http://bugreports.qt.nokia.com/browse/QTBUG-54
**************
Since X11 headers are not namespace safe, they have to be included after Qt headers. Generally, headers should always be included in the order from the most specialized to the most general one to prevent namespace pollution:

#include "myownheader.h"
#include <someQtHeader.h>
#include <X11/someXheader>
#include <string.h> // system header
**************

Another way to fix it is some magic with "Bool" "Status" defines, but that looks ugly.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.