[Webkit-unassigned] [Bug 54707] Introduce lookup-table based approach for applying CSS properties.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54707





--- Comment #38 from Eric Seidel <eric at webkit.org>  2011-03-07 21:40:09 PST ---
(From update of attachment 84983)
View in context: https://bugs.webkit.org/attachment.cgi?id=84983&action=review

> Source/WebCore/css/CSSStyleApplyProperty.cpp:159
> +    setPropertyValue(CSSPropertyColor, new ApplyPropertyColor(&RenderStyle::color, &RenderStyle::setColor, RenderStyle::initialColor));

I wonder if these even need to/want to be heap allocated.  I'm not sure it really matters, since we allocate them once, up-front.  But it seems this is just a jump table you're making, and you could use either struct-allocation, or just copy construct stack objects. I guess that wouldn't work with the current design of using virtual functions however.

Again, this is all stuff we can iterate on.  I stongly support moving to a more object oriented approach which this patch moves us towards.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.