[Webkit-unassigned] [Bug 55115] Add support for DataTransferItems

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55115


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #85010|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #25 from David Levin <levin at chromium.org>  2011-03-07 21:23:38 PST ---
(From update of attachment 85010)
View in context: https://bugs.webkit.org/attachment.cgi?id=85010&action=review

Please fix the items commented on and check in.

> Source/WebCore/dom/DataTransferItem.h:44
> +public:

Need virtual destructor.

> Source/WebCore/dom/DataTransferItems.h:46
> +public:

Add virtual destructor.

> Source/WebCore/dom/StringCallback.cpp:43
> +    static DispatchCallbackTask* create(PassRefPtr<StringCallback> callback, const String& data)

return type should be PassOwnPtr<>

> Source/WebCore/dom/StringCallback.cpp:45
> +        return new DispatchCallbackTask(callback, data);

Should be "return adoptPtr(new ..."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.