[Webkit-unassigned] [Bug 55719] [Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 7 18:49:10 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=55719


Oleg Romashin (:romaxa) <romaxa at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84907|0                           |1
        is obsolete|                            |
  Attachment #84907|review?                     |
               Flag|                            |




--- Comment #27 from Oleg Romashin (:romaxa) <romaxa at gmail.com>  2011-03-07 18:49:09 PST ---
Created an attachment (id=85008)
 --> (https://bugs.webkit.org/attachment.cgi?id=85008&action=review)
Fixed some review comments,

moved createWebProcessConnection to platform specific implementation, fixed changed to assert_not_reached
asked kling about ComplexTextInput and he proposed to keep that Qt IME implementation.

m_connection->send(Messages::PluginProcessProxy::DidCreateWebProcessConnection(clientPort), 0); - is called only from PluginProcess::createWebProcessConnection, which is not implemented yet in Qt port.
lets keep DidCreateWebProcessConnection mac only for now, and change that when some implementation for Qt createWebProcessConnection is done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list