[Webkit-unassigned] [Bug 55902] selectionHasStyle and selectionStartHasStyle should use EditingStyle

Mon Mar 7 18:06:27 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=55902

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84994|review?                     |review+
               Flag|                            |

--- Comment #4 from Darin Adler <darin at apple.com>  2011-03-07 18:06:27 PST ---
(From update of attachment 84994)
View in context: https://bugs.webkit.org/attachment.cgi?id=84994&action=review

> Source/WebCore/editing/EditingStyle.cpp:516
> +// CSS properties that only has a visual difference when applied to text.

Verb agreement problem here. Should be “have” instead of “has”.

But I think the verb “create” is better.

> Source/WebCore/editing/EditingStyle.cpp:527
> +    RefPtr<CSSMutableStyleDeclaration> diff = getPropertiesNotIn(m_mutableStyle.get(), styleToCompare);

Even though diff is a “term of art”, I would use the word “difference” here in this code you moved.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.