[Webkit-unassigned] [Bug 55257] Support creating compositing layers for scrollable and overflowing objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55257





--- Comment #31 from James Robinson <jamesr at chromium.org>  2011-03-07 17:09:38 PST ---
(From update of attachment 85000)
View in context: https://bugs.webkit.org/attachment.cgi?id=85000&action=review

Does the bug title still accurately describe what this patch does?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1264
> +    if (!box->canBeProgramaticallyScrolled(false))

It seems like this isn't quite the right test - at least to start it sounds like you are more interested in boxes that can be scrolled by user interaction, not just by javascript manipulating scrollTop/scrollLeft.

There's also a canBeScrolledAndHasScrollableArea() helper function on RenderBox that encapsulates this and the scrollWidth/Height vs clientWidth/Height checks you are doing on lines 1289-1290.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1282
> +    if (contentBox.height() * contentBox.width() <= 1)

This deserves a comment and a test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.