[Webkit-unassigned] [Bug 54707] Introduce lookup-table based approach for applying CSS properties.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54707





--- Comment #31 from Luke Macpherson <macpherson at chromium.org>  2011-03-07 15:53:01 PST ---
(In reply to comment #30)
> (In reply to comment #28)
> > Performance numbers:
> > 
> > Loading wsj.com from a locally cached version @ 20uS sample rate using shark on OSX.
> > JS and flash were disabled during testing to improve repeatability.
> > These are counts of the samples taken in CSSStyleSelector::applyProperty().
> 
> Am I reading correctly that your patch makes applyProperty hotter?  What about total time running the PLT or laying out wsj.com?

There are two sets of results there - modified without inlining was spending more time in applyProperty (ie slower), then I fixed the inlining issues by moving some code into the header, and now it is spending less time in applyProperty (ie. faster). The last set of results correspond to the last patch uploaded.

Let me know if I can make this clearer, but the bottom line is that we now spend slightly less time in applyProperty and its children, for a net speed-up. I expect this will improve further as more properties are converted over.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.