[Webkit-unassigned] [Bug 55236] [Chromium] .checksum files without .pngs and vice-versa

Mon Mar 7 14:43:26 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=55236

--- Comment #6 from Dirk Pranke <dpranke at chromium.org>  2011-03-07 14:43:26 PST ---
(From update of attachment 84809)
View in context: https://bugs.webkit.org/attachment.cgi?id=84809&action=review

Looks fine otherwise.

> Tools/Scripts/find-mismatched-results:51
> +        option_parser.error("Please --missing-pngs or --missing-checksums.")

Nit. "Please specify either ..."

> Tools/Scripts/find-mismatched-results:55
> +            '..', '..', 'LayoutTests')]

Nit. Should replace this with a webkitpy routine to find the top of the tree. Unfortunately, common.checkout.scm.find_checkout_root() doesn't really do the right thing. layout_tests.port.get().path_from_webkit_base('LayoutTests') should, I think. Maybe add a FIXME?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.