[Webkit-unassigned] [Bug 30816] [GTK] Failing test fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30816


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84827|review?                     |review+
               Flag|                            |




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2011-03-07 11:30:08 PST ---
(From update of attachment 84827)
View in context: https://bugs.webkit.org/attachment.cgi?id=84827&action=review

I tested this change locally and the test is now passing on GTK+. Thanks for the cleanup!

> LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html:13
> +    var expectedOffset = 29;

Might want to leave a comment here explaining where 29 comes from.

> LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html:16
> +    function check(message, event)

I recommend naming this function something a bit more descriptive.

> LayoutTests/fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html:18
> +        var range =document.caretRangeFromPoint(event.clientX, event.clientY);

Missing a space after the equal sign here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.