[Webkit-unassigned] [Bug 25533] Elements on the same line should be treated as such by caret navigation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 7 09:53:20 PST 2011


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
  Attachment #84236|0                           |1
        is obsolete|                            |

--- Comment #18 from Mario Sanchez Prada <msanchez at igalia.com>  2011-03-07 09:53:19 PST ---
Created an attachment (id=84953)
 --> (https://bugs.webkit.org/attachment.cgi?id=84953&action=review)
WIP: (incomplete) patch for fixing the bug

I've been working lately on this bug but couldn't find a reliable patch for it yet, that is, I have a patch that seems to improve the situation but still makes some other tests to fail, which means is not correct yet and need further work.

However, due to other constraints currently out of my control, I need to temporarily stop working on this bug and move on to another task, so I'm attaching the patch with the current status of the patch I have, hoping I can resume work on this stuff soon at some point in the next months, or simply for the sake of sharing it in case someone else wished to step up finishing it during the meantime.

Hence, not asking for review over the attached patch.

(In reply to comment #17)
> > Yes.  You should be changing the behavior of up/down on all platforms because the current behavior is inconsistent with TextEdit, Firefox, etc...
> Gotcha. So no more MoveCaretUp/Down command, let's fix MoveUp/Down instead.

Did it that way. Now I just need to fix those failing tests :-)

> > > Could you provide some guidance, even roughly, about how this could be done then? I'm not fond on this so deep issues in editing stuff and probably I'm missing something :-)
> > 
> > Given my comment above, I'd guess that you need to modify SelectionController.cpp and visible_units.cpp but not EditorCommand.cpp.
> Now I understood why I shouldn't be creating new commands, this makes a lot of sense to me as well.
> Still fix for bug 55481 keeps being a dependency for this so I'll base my work on that one, hoping it will be accepted at some point :-)

As I said here, I used patch for 55481 as a dependency for this one, as it's crucial not to get stuck on objects with non-zero padding/border when navigating vertically.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list