[Webkit-unassigned] [Bug 55873] Use HashMaps for caching primitive values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55873


Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84939|review?                     |review+
               Flag|                            |




--- Comment #4 from Sam Weinig <sam at webkit.org>  2011-03-07 09:00:35 PST ---
(From update of attachment 84939)
View in context: https://bugs.webkit.org/attachment.cgi?id=84939&action=review

> Source/WebCore/css/CSSPrimitiveValueCache.cpp:119
> +    RefPtr<CSSPrimitiveValue> primitiveValue = cache->get(intValue);
>      if (!primitiveValue) {
>          primitiveValue = CSSPrimitiveValue::create(value, type);
> -        m_integerValueCache[intValue][type] = primitiveValue;
> +        cache->add(intValue, primitiveValue);
>      }

Same comment as the the one mitz gave above. This can be done with one hash lookup.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.