[Webkit-unassigned] [Bug 55719] [Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55719





--- Comment #25 from Balazs Kelemen <kbalazs at webkit.org>  2011-03-07 02:13:02 PST ---
(From update of attachment 84907)
View in context: https://bugs.webkit.org/attachment.cgi?id=84907&action=review

Informal review from a non-reviewer.

Generally I thing we should first design how to make things more portable.
Btw, why do you think all platforms need the complex text stuff?
It seems to be pretty Mac specific.

> Source/WebKit2/PluginProcess/PluginProcess.cpp:135
> -    // FIXME: This is platform specific!
> -
> +#if PLATFORM(MAC)
>      // Create the listening port.
>      mach_port_t listeningPort;
>      mach_port_allocate(mach_task_self(), MACH_PORT_RIGHT_RECEIVE, &listeningPort);

This function should rather be factored to be a platform specific one that is implemented per platform...

> Source/WebKit2/PluginProcess/PluginProcess.cpp:148
> +#else
> +    ASSERT(false);
> +#endif

and than this should be removed.

> Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:131
> +#else
> +        ASSERT(false);
> +#endif

Use ASSERT_NOT_REACHED(). It's an open question however how to abstract an empty message in a platform independent way.
Maybe we should solve this before actually adding even a stub implementation for plugin process.

> Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:212
>      CoreIPC::ArgumentEncoder* reply = m_pendingConnectionReplies.first().second;
>      m_pendingConnectionReplies.removeFirst();
>  
> -    // FIXME: This is Mac specific.
>      reply->encode(CoreIPC::MachPort(machPort.port(), MACH_MSG_TYPE_MOVE_SEND));
> +
>      replyWebProcessProxy->connection()->sendSyncReply(reply);
>  }
> +#endif

Similar issue. It is not good having this to be implemented per platform just because of the MachPort argument.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.