[Webkit-unassigned] [Bug 54594] Expose isValidProtocol() in KURL.h.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54594





--- Comment #17 from David Levin <levin at chromium.org>  2011-03-06 22:24:24 PST ---
(In reply to comment #16)
> dave_levin have been working to remove duplicated code in KURL.cpp and KURLGoogle.cpp.  I noticed this comment:
> 
> + // NOTE This is a copy of the function in KURL.cpp.
> 
> Maybe we can move this function outside the ifdef so we don't have to copy/paste it?

Yes, please do (see the bottom of KURL.cpp). (It seems silly to duplicate code between these two files for things that are identical so I got rid of some. Let's not add more.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.