[Webkit-unassigned] [Bug 54374] Add method to make BuildBot return test outputs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54374





--- Comment #13 from James Kozianski <koz at chromium.org>  2011-03-06 19:48:25 PST ---
(In reply to comment #11)
> (From update of attachment 83604 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83604&action=review
> 
> > Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:237
> > +    def results_zip_url(self):
> > +        return "%s.zip" % self.results_url()
> > +
> > +    def results(self):
> > +        return TestOutputSet(self._builder.name(), None, ZipFileSet(self.results_zip_url()), include_expected=False)
> > +
> 
> I know this is a bit inane, but can you write tests for these too. They don't need to actually verify the output. It just ensures that they run without errors.
> 
> results_zip_url can just verify that it gets the right string back and TestOutputSet can just verify that it gets a non-None value back.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.