[Webkit-unassigned] [Bug 55839] Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.

Sun Mar 6 18:31:38 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=55839

Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84885|review?                     |review-
               Flag|                            |

--- Comment #4 from Kent Tamura <tkent at chromium.org>  2011-03-06 18:31:38 PST ---
(From update of attachment 84885)
View in context: https://bugs.webkit.org/attachment.cgi?id=84885&action=review

Thank you for working on this.

> LayoutTests/ChangeLog:6
> +        [Chromium] Issue 73866: Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.
> +        https://bugs.webkit.org/show_bug.cgi?id=55839

I guess this problem occurs on all of platforms with inner spin button, such as Apple Windows and Chromium-Linux.  So we should remove "[Chromium] Issue 73866: " from the description.
You may add http://crbug.com/73866 next to the bugs.webkit.org URL.

> LayoutTests/ChangeLog:8
> +        * fast/forms/input-appearance-spinbutton-visibility.html: Added.

We should add expectation files.

> LayoutTests/fast/forms/input-appearance-spinbutton-visibility.html:1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

nit: <!DOCTYPE html> is enough.

> LayoutTests/fast/forms/input-appearance-spinbutton-visibility.html:4
> +<link rel="stylesheet" href="../../../../fast/js/resources/js-test-style.css">

The path looks wrong.  It should be ../js/resource/js-test-style.css ?
Anyway, I don't hink we need js-test-style.css for this test.

> LayoutTests/fast/forms/input-appearance-spinbutton-visibility.html:8
> +input {
> +    font-size: 20px;
> +}

The test doesn't depend on font-size.  We don't need this line.

> LayoutTests/fast/forms/input-appearance-spinbutton-visibility.html:12
> +<p>Test visibility of spin buttons. The number input text area hidden by "visibility:hidden" becomes visible with Javascript visibility change.</p>

Please make this paragraph an HTML comment like 
We should avoid text in pixel tests as possible.

> Source/WebCore/ChangeLog:5
> +        [Chromium] Issue 73866: Input type=number spin buttons remain invisible but functional after div changed from hidden to visible.

Remove "[Chromium] Issue 73866: "

> Source/WebCore/ChangeLog:10
> +        Test: fast/forms/input-appearance-spinbutton-visibility.html

I guess this patch also fixes http://code.google.com/p/chromium/issues/detail?id=62527.
If so, would you add another test for it please?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.