[Webkit-unassigned] [Bug 55853] New: Move MD5/SHA1 tests to somewhere outside their constructors

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 6 18:05:51 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=55853

           Summary: Move MD5/SHA1 tests to somewhere outside their
                    constructors
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: yutak at chromium.org
                CC: tkent at chromium.org


WTF::MD5 and WTF::SHA1 classes run unit tests in their constructors. We should move these somewhere else.

Comment from Kent Tamura in bug 55039:
> I don't like having tests in SHA1.cpp and they are called by the constructor though I understand it's same as MD5.
> Would you file a bug about the test location of SHA1 and MD5, and add a FIXME comment please?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list