[Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 6 17:52:31 PST 2011


Kevin Ollivier <kevino at theolliviers.com> changed:

           What    |Removed                     |Added
  Attachment #84895|0                           |1
        is obsolete|                            |
  Attachment #84895|review?                     |
               Flag|                            |
  Attachment #84903|                            |review?
               Flag|                            |

--- Comment #82 from Kevin Ollivier <kevino at theolliviers.com>  2011-03-06 17:52:29 PST ---
Created an attachment (id=84903)
 --> (https://bugs.webkit.org/attachment.cgi?id=84903&action=review)
Retry - Step 1 re-submit w/attempts at GTK, Qt and Win build fixes.

New try with build fixes for the ports broken by the patch. Not really sure if I should address the style bot issues.... It would seem inconsistent to remove the variable name from that one variable while leaving all the others in there. 

Also, in case anyone familiar with Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp is reading, is there any reason the file doesn't just do:

#if defined(WIN32) || defined(_WIN32)
#include "config.h"
// set defines needed on Mac due to missing config.h

Most of the defines set in there are for the Win32 case, which from the comment should have access to config.h, it is only the Mac port that is without it. I could set a different bug for that if there's interest in having it handled but doing it in this patch isn't appropriate.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list