[Webkit-unassigned] [Bug 42432] Enable Web Timing for GTK

Sat Mar 5 09:35:20 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=42432

Zan Dobersek <zandobersek at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83292|0                           |1
        is obsolete|                            |
  Attachment #84869|                            |review?, commit-queue?
               Flag|                            |

--- Comment #2 from Zan Dobersek <zandobersek at gmail.com>  2011-03-05 09:35:20 PST ---
Created an attachment (id=84869)
 --> (https://bugs.webkit.org/attachment.cgi?id=84869&action=review)
Patch 1: Implementation

This patch brings (incomplete) support for the Navigation Timing specification to the Gtk port.

I consider the support incomplete because the domain lookup times are not set. Libsoup at this moment does not offer signals we could connect to in order to get notified when domain lookup starts or ends. As/If they're added, the implementation should be properly updated.

Another small hack this implementation utilizes is setting the connectEnd time when we receive response. Dan Winship recommended on the libsoup mailing list[1] this could be done by connecting to SoupConnection's notify::state signal which is emitted when state of the connection changes. When state would change from SOUP_CONNECTION_CONNECTING to any other it would mean that connection has ended (successfully or unsuccessfully, it does not matter in this case) and the connectEnd attribute should be assigned the current time.

This proved unusable when testing. Because the SoupConnection object is 'semi-private API' (and is on its way to be replaced by a more 'gio-oriented API', explained in the message by Dan) there is no reasonable way to add the SoupConnection to a ResourceHandle so we could disconnect signal handlers when ResourceHandle is deleted. This was shown in testing by crashes when trying to access ResourceLoadTiming object of the ResourceHandle's response. I'd like to see this properly implemented when libsoup makes the change in the API, though.

[1] https://mail.gnome.org/archives/libsoup-list/2011-February/msg00004.html

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.