[Webkit-unassigned] [Bug 55816] Web Inspector: fix layout tests flakiness.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55816





--- Comment #5 from Pavel Feldman <pfeldman at chromium.org>  2011-03-05 00:33:23 PST ---
(In reply to comment #3)
> (From update of attachment 84846 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84846&action=review
> 
> > LayoutTests/http/tests/inspector/inspector-test.js:331
> > +        var intermediate = document.createElement("div");
> 
> Why do you need this?
> 

So that output was not the top-level element and was not generating DOM events upon every addResult invocation.

> > LayoutTests/inspector/console/console-uncaught-exception-expected.txt:6
> > +console-uncaught-exception.html:40Error: Exception in inline script.
> 
> Chromium has stack traces for uncaught exceptions when front-end is open, this is why we need to reload inspected page. I don't see changes to the chromium-specific expectations in this patch. r- for this.

Uploading patch with proper expectations and flow.


> How can you be sure that frontend is already loaded when the exceptions are thrown?
> 

See above.

> > Source/WebCore/inspector/InspectorAgent.cpp:399
> > +    m_pendingEvaluateTestCommands.clear();
> 
> Why do we need this magic?

When single inspector agent is reused, we'd like to clear potential pending messages so that they don't get fired with the next front-end. This is a paranoid check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.