[Webkit-unassigned] [Bug 55440] improve layout performance by reducing the traversal time of the floating objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55440





--- Comment #18 from Yuqiang Xian <yuqiang.xian at intel.com>  2011-03-04 16:00:47 PST ---
(In reply to comment #15)
> (From update of attachment 84682 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84682&action=review
> 
> Can we double check that increase/decrease is called in all the right places?
> 
> I’m going to say review+ even though I think we may want a little more refinement.
> 

Thanks for the review. Yes I've checked the places of adding/removing the floating objects. There're 3 "add" and 2 "remove" in RenderBlock.cpp and nothing elsewhere. The corresponding increase/decrease is called in such place. 
Maybe in the future we could make that be automatically performed, for example bridging the add/remove calls through FloatingObjects. I just didn't do that this time because there're many other functions which add or remove objects in FloatingObjectSet class and if we bridge all of them the FloatingObjects class would become somewhat complex.
I'll address the refinement in another change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.