[Webkit-unassigned] [Bug 55719] [Qt][WK2] Make Qt port compiling with ENABLE_PLUGIN_PROCESS=1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 4 15:08:19 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=55719


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84797|review?                     |review+
               Flag|                            |




--- Comment #11 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-03-04 15:08:19 PST ---
(From update of attachment 84797)
View in context: https://bugs.webkit.org/attachment.cgi?id=84797&action=review

Seems pretty OK to me as a start.

> Source/WebKit2/PluginProcess/qt/PluginProcessMainQt.cpp:47
> +    notImplemented();
> +

Things are implemented in this method

> Source/WebKit2/PluginProcess/qt/PluginProcessMainQt.cpp:52
> +    String localization = commandLine["localization"];

I do not see what that does here. It is not used anywhere

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list