[Webkit-unassigned] [Bug 55609] option to use skia's font backend when drawing text on windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 4 13:31:48 PST 2011


James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
  Attachment #84781|review?                     |review+
               Flag|                            |

--- Comment #6 from James Robinson <jamesr at chromium.org>  2011-03-04 13:31:48 PST ---
(From update of attachment 84781)
View in context: https://bugs.webkit.org/attachment.cgi?id=84781&action=review

Looks good.  If you'd like I can fix the comment nitpicks and land myself, or you can upload a new patch for commit-queue.

> WebCore/platform/graphics/skia/SkiaFontWin.cpp:287
> +    // reallocate space on the stack. If numGlyphs is larger, the array
> +    // will dynamically alocate it.

nit: "reallocate" -> "Initially allocate space on the stack for 64 entries" or something like that.
"alocate" -> "allocate".

> WebCore/platform/graphics/skia/SkiaFontWin.cpp:335
> +        size = -size; // we don't let GDI dpi-scale us (see SkFontHost_win.cpp

Thanks for the comment.  nits: "we"->"We", needs a trailing ")."

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list