[Webkit-unassigned] [Bug 55717] On Mac, the bounding box sent to EditorClient::showCorrectionPanel() is incorrect when the correction occurs in an iframe.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 4 10:43:08 PST 2011


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
  Attachment #84767|review?                     |review+
               Flag|                            |

--- Comment #6 from Darin Adler <darin at apple.com>  2011-03-04 10:43:09 PST ---
(From update of attachment 84767)
View in context: https://bugs.webkit.org/attachment.cgi?id=84767&action=review

> Source/WebCore/dom/Range.cpp:1907
>      if (!m_start.container())
>          return 0;

This code isn’t needed any more.

> Source/WebCore/dom/Range.cpp:1979
> +    for (size_t i = 0; i< quads.size(); ++i)

Missing space here before the "<".

> Source/WebCore/editing/Editor.cpp:3609
> +FloatRect Editor::rectToWindow(const FloatRect& rect) const

The function I was suggested we factor out was actually windowRectForRange, ranking a Range*.

> Source/WebCore/editing/Editor.h:434
> +    // Convert abolustion (page) coordinate to window space


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list