[Webkit-unassigned] [Bug 55603] [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55603


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84590|review?                     |
               Flag|                            |




--- Comment #9 from Martin Robinson <mrobinson at webkit.org>  2011-03-04 09:09:26 PST ---
(From update of attachment 84590)
View in context: https://bugs.webkit.org/attachment.cgi?id=84590&action=review

>>>> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:527
>>>> +
>>> 
>>> You should move the line *start = *length = 0; after the g_return_val_if_fail(start && length, false);
>> 
>> I feel that the method should return conssitent values when it fails. Is there a particular reason it's better to move it down? Externally the user of the method couldn't know if it returned false because of a bad argument or one of the following runtime situations.
> 
> The macro checks that valid pointers have been passed, so you shouldn't use the pointers before it.

Ah! Quite right. I'll reorder the statement and upload a new patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.