[Webkit-unassigned] [Bug 55685] Web Inspector: [Text editor] Do bisect to find visible chunks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55685


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84576|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2011-03-04 02:01:17 PST ---
(From update of attachment 84576)
View in context: https://bugs.webkit.org/attachment.cgi?id=84576&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:408
> +    _findVisibleChunks: function(visibleFrom, visibleTo)

You should use insertionIndexForObjectInListSortedByFunction from utilities.js (and you can rename it to binarySearch).

> Source/WebCore/inspector/front-end/TextViewer.js:661
> +        return this._expandedLineRows ? this._expandedLineRows[0].offsetTop : this.element.offsetTop;

What does this logic do?

> Source/WebCore/inspector/front-end/TextViewer.js:1580
> +        return this._expandedLineRows ? this._expandedLineRows[0].offsetTop : this.element.offsetTop;

ditto. Also, I see that gutter chunk and main chunk have a lot in common. This does not sound right.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.