[Webkit-unassigned] [Bug 10313] xsl:import and document() don't work in stylesheets loaded via XMLHttpRequest

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=10313





--- Comment #78 from Adam Barth <abarth at webkit.org>  2011-03-04 00:31:21 PST ---
(From update of attachment 84578)
View in context: https://bugs.webkit.org/attachment.cgi?id=84578&action=review

>> Source/WebCore/xml/DOMParser.h:35
>> -    PassRefPtr<Document> parseFromString(const String&, const String& contentType);
>> +    PassRefPtr<Document> parseFromString(ScriptExecutionContext*, const String& str, const String& contentType);
> 
> The parameter name "str" adds no information, so it should be removed.  [readability/parameter_name] [5]

This "str" you added!

>> Source/WebCore/xml/XSLTProcessor.h:51
>> -    PassRefPtr<Document> createDocumentFromSource(const String& source, const String& sourceEncoding, const String& sourceMIMEType, Node* sourceNode, Frame* frame);
>> +    PassRefPtr<Document> createDocumentFromSource(const String& source, const String& sourceEncoding, const String& sourceMIMEType, Node* sourceNode, Frame* frame, ScriptExecutionContext*);
> 
> The parameter name "frame" adds no information, so it should be removed.  [readability/parameter_name] [5]

This one is definitely worth fixing since you're touching this line and "Frame* frame" is totally vacuous.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.