[Webkit-unassigned] [Bug 55257] Support creating compositing layers for scrollable and overflowing objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55257





--- Comment #16 from Daniel Sievers <sievers at google.com>  2011-03-03 18:32:44 PST ---

> In chromium we don't SKIP tests unless they cause the test harness to crash in some way.  Instead set the appropriate expectation ( = TEXT or whatnot).

Fixed.


> I'm a bit confused here - why do we need the two checks?  Does isRootLayer not indicate whether the layer is a root layer?
> > +        if (frameView->layoutWidth() <= 1 || frameView->layoutHeight() <= 1)


see comment above, unfortunately isRootLayer() is misleading and just returns whether it's a RenderView, so could also be an (i)frame.

> 
> This still feels redundant with the check at 1310.  If we don't want to make compositing layers for small things, we should just do the size check once IMO.

Removed.

> Supporting scrolling="no" on an iframe is a separate issue - please file another bug on this and attach this code + the corresponding test(s) to that bug.

Removed, will file a separate bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.