[Webkit-unassigned] [Bug 55257] Support creating compositing layers for scrollable and overflowing objects

Thu Mar 3 18:15:13 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=55257

--- Comment #13 from James Robinson <jamesr at chromium.org>  2011-03-03 18:15:13 PST ---
(In reply to comment #7)
> I have made the following changes:
> 
> * added layout tests with expected output (graphics layer tree).
> I had problems adding a runtime property to LayoutTestController::overridePreference(), because RenderLayerCompositor() caches m_compositingTriggers when it is first created so triggering a change from Javascript won't propagate properly. Therefore I have marked the tests as SKIPPED for now.

Take a look at RenderLayerCompositor::cacheAcceleratedCompositingFlags() and its caller - I think the problem you are having has been solved.

> 
> * In RenderLayerCompositor::requiresCompositingForScrollableOverflow() I have moved the root layer check up so that we don't always set m_compositingDependsOnGeometry.
> 
> * I have overwritten canBeProgramaticallyScrolled() for RenderView so that it correctly returns false now for frames and iframes with the 'scrolling' attribute set to 'no', and we don't create an unwanted layer.

This is nifty, but should be done in a separate bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.