[Webkit-unassigned] [Bug 55704] Not all plugins should be opted out of 32-bit NX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55704


Ivan Krstić <ike at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ike at apple.com




--- Comment #7 from Ivan Krstić <ike at apple.com>  2011-03-03 18:08:20 PST ---
This patch is confused. The ChangeLog states that Silverlight and QuickTime should opt *in* to a 32-bit NX heap, which means their heap should not be executable. But then it opts them *out* by making pluginNeedsExecutableHeap() claim that those two plugins need an executable heap — i.e. that they cannot run with NX. It also opts all other plugins into running with an NX heap.

Assuming you're really trying to say "QuickTime and Silverlight should run with a non-executable heap (opt-in), and other plugins should have an executable one (opt-out)", you need to invert your true/false returns in pluginNeedsExecutableHeap.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.