[Webkit-unassigned] [Bug 55453] Pass preferred language information down to font fallback logic

Thu Mar 3 17:06:33 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=55453

Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84584|review?                     |review-
               Flag|                            |

--- Comment #16 from Tony Chang <tony at chromium.org>  2011-03-03 17:06:33 PST ---
(From update of attachment 84584)
View in context: https://bugs.webkit.org/attachment.cgi?id=84584&action=review

r- because this patch is missing a ChangeLog entry.  Also, shouldn't there be a LayoutTest?

> WebKit/chromium/public/gtk/WebFontInfo.h:53
> -    WEBKIT_API static WebCString familyForChars(const WebUChar* characters, size_t numCharacters);
> +    WEBKIT_API static WebCString familyForChars(const WebUChar* characters, size_t numCharacters, const char* preferredLocale = 0);

Please file a bug about making |preferredLocale| not have a default param after the chromium side is landed and rolled in.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.