[Webkit-unassigned] [Bug 53707] Viewport Warning/Error Messages Are Now Inaccurate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53707





--- Comment #39 from Joseph Pecoraro <joepeck at webkit.org>  2011-03-03 15:26:20 PST ---
> a) without target-densitydpi argument (assuming target-densitydpi of 160)
> 
> device-width = real width / (real dpi / target-densitydpi) = 480 / (240 / 160) = 480 / 1.5 = 320.
> 
> b) with target-densitydpi = device-dpi (which is 240)
> 
> device-width = real width / (real dpi / target-densitydpi) = 480 / (240 / 240) = 480 / 1.0 = 480.

Okay, that is much clearer, Thanks!



> It all comes down to how useful these warnings are. You could say that if
> someone knows how to use target-densitydpi, he surely also knows how
> to use device-width. It could even be that the user actually wanted 480
> always and just wanted the scale to change to fit the 480 into the given
> view. I have seem many such cases.

In that case, it sounds to me like, with target-densitydpi in the mix, these
tips aren't as useful as they used to be. I'm fine with removing them. It
would greatly simplify the patch as well because I wouldn't need to touch
all the other ports.

However, if we want to improve the tip, what would be a good suggestion?
After Document::processViewport processes the ViewportArguments, we
could look at the end result and present some tips or warnings. I can't
think of any good ones off the top of my head.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.