[Webkit-unassigned] [Bug 55644] [fileapi] Add URI resolution support to WorkerContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55644





--- Comment #10 from Adam Klein <adamk at chromium.org>  2011-03-03 14:10:49 PST ---
(From update of attachment 84604)
View in context: https://bugs.webkit.org/attachment.cgi?id=84604&action=review

>> Source/WebCore/ChangeLog:9
>> +        in the WebKit Chromium builds.
> 
> Why are are adding more stuff here if none of it is testable? (I thought I saw some tests for the file system in workers but maybe not.)
> 
> If they aren't testable, can we fix that before adding more here.

Thanks for calling me on this. Kinuko, can you help here?  Last time I tried to run the worker tests they just hung.

>> Source/WebKit/chromium/src/LocalFileSystemChromium.cpp:77
>> +    openFileSystemHelper(context, type, callbacks, synchronous, 0, false);
> 
> That last parameter should be an enum instead of a bool to make the call sites more readable.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.