[Webkit-unassigned] [Bug 55644] [fileapi] Add URI resolution support to WorkerContext

Thu Mar 3 13:58:10 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=55644

David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84604|review?                     |review-
               Flag|                            |

--- Comment #8 from David Levin <levin at chromium.org>  2011-03-03 13:58:10 PST ---
(From update of attachment 84604)
View in context: https://bugs.webkit.org/attachment.cgi?id=84604&action=review

> Source/WebCore/ChangeLog:9
> +        in the WebKit Chromium builds.

Why are are adding more stuff here if none of it is testable? (I thought I saw some tests for the file system in workers but maybe not.)

If they aren't testable, can we fix that before adding more here.

> Source/WebKit/chromium/src/LocalFileSystemChromium.cpp:77
> +    openFileSystemHelper(context, type, callbacks, synchronous, 0, false);

That last parameter should be an enum instead of a bool to make the call sites more readable.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.