[Webkit-unassigned] [Bug 55017] SVGImage causes MainResourceLoader leaks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55017


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84534|review?                     |review+
               Flag|                            |




--- Comment #31 from Adam Barth <abarth at webkit.org>  2011-03-03 13:07:34 PST ---
(From update of attachment 84534)
View in context: https://bugs.webkit.org/attachment.cgi?id=84534&action=review

I continue to like this patch because it removes cruft from the SVGImage bootup code.  Please give Alexey a chance to suggest an approach for additional testing before landing.  Thanks!

> LayoutTests/fast/images/svg-image-leak-loader.html:6
> +  layoutTestController.dumpAsText();
> +  layoutTestController.waitUntilDone();

We usually use four-space indent in tests, but it doesn't really matter.

> LayoutTests/fast/images/resources/load-script.html:3
> +<script src="XXXXX.js"></script>

I might have called this "does-not-exist.js" so a future reader doesn't need to wonder what XXXXX means.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.