[Webkit-unassigned] [Bug 53707] Viewport Warning/Error Messages Are Now Inaccurate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53707





--- Comment #30 from Joseph Pecoraro <joepeck at webkit.org>  2011-03-03 11:12:38 PST ---
style:
> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:77:  Alphabetical sorting problem.
> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:532:  device_width is incorrectly named. Don't use underscores in your identifier names.
> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:533:  device_height is incorrectly named. Don't use underscores in your identifier names.

Fixed. Updated the older efl style.

qt:
> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp: In function ‘QSize WebCore::queryDeviceSizeForScreenContainingWidget(const QWidget*)’:
> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:724: error: incomplete type ‘QApplication’ used in nested name specifier
> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp: In member function ‘virtual WebCore::FloatSize WebCore::ChromeClientQt::viewportDeviceSize() const’:
> Source/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp:759: error: ‘d’ was not declared in this scope

Fixed. Included qapplication and d is m_webPage->d.

efl:
> fatal: Unable to create '/mnt/eflews/git/webkit/.git/index.lock': File exists.

git issue.

gtk:

> Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h:114: error: 'FloatSize' does not name a type
> Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:654: error: no 'WebCore::FloatSize WebKit::ChromeClient::viewportDeviceSize() const' member function declared in class 'WebKit::ChromeClient'

Fixed. Forgot namespace, so WebCore::FloatSize.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.