[Webkit-unassigned] [Bug 55603] [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55603





--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2011-03-03 10:57:59 PST ---
(In reply to comment #2)
> I don't think using g_return_* macros everywhere is a good idea. Those macros are not just early returns, are more like an assert that doesn't abort, they log a critical warning, if you have ciriticals=fatal it will crash on an assertion. g_return_* macros are used to protect public methods checking the input and logging a critical message when something is not expected, to easily catch bugs. Since they are inefficient you can build glib with G_DISABLE_CHECKS (it's usually done in production builds for performance reasons) which makes those macros do nothing (#define g_return_if_fail(expr) (void)0;)

Excellent point. I've uploaded a new patch that conforms to the following policy:

1. When there is an API that accepts a GObject, arguments are verified with GLib style early returns (g_return_ macros).

2. Assertions are used for non-API arguments and values computed at runtime.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.