[Webkit-unassigned] [Bug 45423] [Gtk] Port tiled backing store

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=45423





--- Comment #50 from Gustavo Noronha (kov) <gns at gnome.org>  2011-03-03 07:13:27 PST ---
(From update of attachment 81801)
View in context: https://bugs.webkit.org/attachment.cgi?id=81801&action=review

> Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:389
> +#if ENABLE(TILED_BACKING_STORE)
> +        Frame* frame = core(m_webView)->mainFrame();
> +        if (frame && frame->tiledBackingStore())
> +            frame->tiledBackingStore()->invalidate(updateRect);
> +#endif

While trying integrating this work on the clutter port I found out that this is wrong and makes babies cry. This is precisly the method the backing store uses to let WebKit know it should update the view from the backing store contents when it's done painting, so invalidating the backing store here causes us to enter an infinite loop. It does not lock up in a tight loop simply because the backing store uses a timer to process updates, and delays them for a few ms, but it's easy to see the problem given the CPU usage being high and responsiveness decreasing over time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.