[Webkit-unassigned] [Bug 53707] Viewport Warning/Error Messages Are Now Inaccurate

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 3 02:54:46 PST 2011


--- Comment #28 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-03-03 02:54:45 PST ---
(From update of attachment 84525)
View in context: https://bugs.webkit.org/attachment.cgi?id=84525&action=review

> Source/WebCore/dom/ViewportArguments.cpp:226
> +        FloatSize deviceSize = page->chrome()->client()->viewportDeviceSize();

In reality with our dpi adjustment, this should be something like FloatSize deviceSize = page->chrome()->client()->viewportDeviceSize() / pixelRatio;

For instance on the iPhone 4, if im not wrong, device-width will report 320, there in reality it is 640. ie, 640 / 2.0 = 320.

The Android extensions makes it possible to avoid this upscaling of the contents, by setting target-densitydpi = device-dpi, so we need to make sure that is parsed at this time.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list