[Webkit-unassigned] [Bug 10313] xsl:import and document() don't work in stylesheets loaded via XMLHttpRequest

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=10313





--- Comment #73 from Adam Barth <abarth at webkit.org>  2011-03-02 22:31:11 PST ---
(From update of attachment 84430)
View in context: https://bugs.webkit.org/attachment.cgi?id=84430&action=review

> Source/WebCore/loader/DocumentThreadableLoader.cpp:364
> +        KURL referrer(m_document->url());
> +        referrer.setUser(String());
> +        referrer.setPass(String());
> +        referrer.removeFragmentIdentifier();

There's a method on KURL that does this now.

> Source/WebCore/xml/DOMParser.cpp:37
> +        doc->setSecurityOrigin(static_cast<Document*>(scriptExecutionContext)->securityOrigin());
> +        doc->setOriginDocument(static_cast<Document*>(scriptExecutionContext));

This is all very scary.  At a bare minimum, please add an assert that we're on the main thread.

> Source/WebCore/xml/XMLHttpRequest.cpp:254
>              m_responseXML->setSecurityOrigin(document()->securityOrigin());
> +            m_responseXML->setOriginDocument(document());

It seems redundant to have a document and an origin set this way.  We can get the origin from the document.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.