[Webkit-unassigned] [Bug 34959] [Qt] QtLauncher does not load the same set of fonts as the DRT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34959





--- Comment #20 from Balazs Kelemen <kbalazs at webkit.org>  2011-03-02 16:13:37 PST ---
(In reply to comment #19)
> I'll try my hand at this one.  You can assign it to me if you like.
> 
> If I understand this correctly, I just need to move/copy the font
> loading code from DumpRenderTreeQt.cpp that reads in the fonts from
> WEBKIT_TESTFONTS into the QtTestBrowser.  This code should be
> projected with an option.  I would suggest -webkit-testfonts or
> -load-webkit-testfonts which seem consistent with the other QtTestBrowser options.

Yep, it's just that. -webkit-testfonts seems to be fine.

> 
> One thing I need to investigate too is that DumpRenderTree loads different
> font.conf files for different platforms.  This file seems to specify font name mappings.  Anyone know if this would be also needed in the QtTestBrowser.
> 

It loads the same checked in config file for every platform: configFile += "/Tools/DumpRenderTree/qt/fonts.conf";
I do not know the role of that file but I guess it is also needed in QTB to get correct visual
result for every test. By the way the approach we use in DRT depends on fontconfig so it is not working
on every platform. You should guard the whole thing with an appropriate ifdef condition that is true on platforms
where fontconfig is presented.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.