[Webkit-unassigned] [Bug 14134] REGRESSION (r25353): Whitespace nodes ignored between inline list items

Wed Mar 2 16:09:14 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=14134

Maciej Stachowiak <mjs at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjs at apple.com

--- Comment #28 from Maciej Stachowiak <mjs at apple.com>  2011-03-02 16:09:14 PST ---
(In reply to comment #27)
> This bug added a renderer walk in attach().  Looking at peacekeeper shark data, this accounts for some 7% of total time out of all the peacekeeper DOM benchmarks combined. :)
> 
> I suspect there is some way to limit the number of times we do this walk w/o regressing this bug?
> 
> Specifically it spends all its time checking node->renderer().  I suspect the walk often misses caches for some reason.  Still investigating.

I don't think it is a cache miss. I think the problem is that you get O(N^2) behavior when replacing all of an element's contents using innerHTML. Note that in this case, the walk should be completely unnecessary. It's only necessary when dynamically inserting before pre-existing children.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.