[Webkit-unassigned] [Bug 55095] IndexedDB: fire versionchange events when calling setVersion

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55095





--- Comment #19 from David Grogan <dgrogan at chromium.org>  2011-03-02 12:19:10 PST ---
(From update of attachment 84099)
View in context: https://bugs.webkit.org/attachment.cgi?id=84099&action=review

>>>> Source/WebCore/storage/IDBDatabase.h:90
>>>> +    virtual bool dispatchEvent(PassRefPtr<Event>);
>>> 
>>> usually we dont' interleave virtual and non-virtual...but this is going away anyway
>> 
>> I kept it around to help make multi-process and single-process chrome do the same things.
> 
> Why was this necessary.  In the future, when you hit stuff that might require a complicated workaround like this, please just ask before writing the code...and explain somewhere why you did what you did.  (Probably in the change log and here.)

Added some explanation to IDBDatabase.h and IDBDatabase::close, will follow up in person.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.