[Webkit-unassigned] [Bug 55567] JavaString API should be implementable by both JSC and V8

Wed Mar 2 11:27:23 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=55567

--- Comment #5 from David Levin <levin at chromium.org>  2011-03-02 11:27:23 PST ---
I reviewed at the same time as jorlow. fwiw, here was my comment:

View in context: https://bugs.webkit.org/attachment.cgi?id=84436&action=review

On a syntax/style level the patch looks fine, but I don't understand what this patch accomplishes.

The stated intent is for something which both v8 and jsc can implement but the v8 implementation is non-existant: "StringImpl* impl() const { ASSERT_NOT_REACHED(); return 0; }"

> Source/WebCore/bridge/jni/v8/JavaStringV8.h:33
> +#include <wtf/text/StringImpl.h>

I believe a fwd declaration with suffice instead of including the header.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.