[Webkit-unassigned] [Bug 44329] SH4 JIT SUPPORT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44329





--- Comment #81 from Oliver Hunt <oliver at apple.com>  2011-03-02 10:31:52 PST ---
(In reply to comment #80)
> (From update of attachment 84424 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84424&action=review
> 
> Style improved a lot, but still some issues. Most of them are valid for whole code.
> 
> > Source/JavaScriptCore/assembler/MacroAssemblerSH4.cpp:32
> > +
> 
> No need for this empty line
> 
> > Source/JavaScriptCore/assembler/MacroAssemblerSH4.h:31
> > +#include "assert.h"

Indeed, assert.h is just wrong -- you should be using <wtf/Assertions.h>

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.