[Webkit-unassigned] [Bug 55567] JavaString API should be implementable by both JSC and V8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55567





--- Comment #2 from David Levin <levin at chromium.org>  2011-03-02 10:04:39 PST ---
(From update of attachment 84407)
View in context: https://bugs.webkit.org/attachment.cgi?id=84407&action=review

> Source/WebCore/bridge/jni/jsc/JavaStringJSC.h:72
> +    PassRefPtr<StringImpl> impl() const { return m_impl; }

"If a function’s result is an object, but ownership is not being transferred, the result should be a raw pointer. This includes most getter functions." -- http://www.webkit.org/coding/RefPtr.html

In other words, this should return StringImpl*.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.