[Webkit-unassigned] [Bug 55585] New: EWS builds patches that fail to build twice, which seems useless and slows down the bots

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55585

           Summary: EWS builds patches that fail to build twice, which
                    seems useless and slows down the bots
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: aroben at apple.com
                CC: eric at webkit.org, abarth at webkit.org,
                    lforschler at apple.com


EWS builds patches that fail to build twice. See this code in AbstractEarlyWarningSystem.review_patch: <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py?rev=76008#L91>

91            if not self._build(patch, first_run=True):
92                if not self._can_build():
93                    return False
94                self._build(patch)

It doesn't seem helpful to build failing patches twice. What would change between the first attempt to build and the second attempt to build?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.