[Webkit-unassigned] [Bug 55017] SVGImage causes MainResourceLoader leaks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55017





--- Comment #22 from Xianzhu Wang <wangxianzhu at google.com>  2011-03-02 05:18:25 PST ---
(In reply to comment #21)
> (From update of attachment 83766 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83766&action=review
> 
> > Source/WebCore/svg/graphics/SVGImage.cpp:279
> > +        if (!loader->activeDocumentLoader())
> > +            loader->init(); // Make sure the DocumentLoader is created
> 
> Why is there a branch here?  This boot-up process should be deterministic.

After comparing the execution paths on chromium-linux and mac, I found I was misled by the execution path on chromium-linux: the code is executed for the first image contained in an SVG document, which seems incorrect. SVGImage shouldn't be created and loaded at all for the tests because no SVG document is used as an embedded image. The execution path doesn't happen on mac webkit.

However, that SVGImage causes MainResourceLoader leaks is still a fact on all platforms thought it should be triggered with different tests. The tests listed in my first bug description just accidentally triggered this issue on chromium-linux (maybe also some other platforms). I will file another bug for the wrong execution path issue on chromium-linux, and create a new test case for this issue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.