[Webkit-unassigned] [Bug 25533] Elements on the same line should be treated as such by caret navigation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25533


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #16 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-02 02:51:21 PST ---
(In reply to comment #15)
> > This is a bug that needs to be fixed on all ports regardless of whether the
> > caret navigation is enabled or not.
> 
> I checked what Chrome and Safari does when moving across a table (not in caret browsing mode, but selecting a single character and then extending the selection with shift+arrows) and I found they traverse tables in the same (wrong?) way: cell by cell in a row by row basis.
> 
> Obviously, my current patch wouldn't fix the behavior for those other ports since I'm defining four new commands precisely not to touch current up/down behavior, but your comment makes me think perhaps I should actually be modifying those current commands, instead of creating new ones.

Yes.  You should be changing the behavior of up/down on all platforms because the current behavior is inconsistent with TextEdit, Firefox, etc...

> > To demonstrate the bug on other ports, simply enable the design mode on the
> > attached test case.
> 
> What do you mean by "enable the design mode"?

document.designMode = 'on';

> > > Source/WebCore/editing/EditorCommand.cpp:620
> > > +static bool isVerticallyCoincident(VisiblePosition origin, VisiblePosition candidate, int originX, SelectionDirection direction)
> > > +{
> > 
> > This is definitely not right.  We shouldn't be adding these selection related
> > code in EditorCommand.cpp, which is supposed to be delegating all the work
> > to the rest of editing code.
> 
> Could you provide some guidance, even roughly, about how this could be done then? I'm not fond on this so deep issues in editing stuff and probably I'm missing something :-)

Given my comment above, I'd guess that you need to modify SelectionController.cpp and visible_units.cpp but not EditorCommand.cpp.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.