[Webkit-unassigned] [Bug 55453] Pass preferred language information down to font fallback logic

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55453





--- Comment #5 from Takayoshi Kochi <kochi at chromium.org>  2011-03-01 23:22:57 PST ---
(From update of attachment 84205)
View in context: https://bugs.webkit.org/attachment.cgi?id=84205&action=review

>> WebKit/chromium/public/gtk/WebFontInfo.h:48
>> +    //   preferredLanguage: preferred language for the characters
> 
> The comment should specify the format of the language. There are (at least) two and three letter forms in use.

Done.

>> WebKit/chromium/public/linux/WebSandboxSupport.h:-53
>> -    virtual WebString getFontFamilyForCharacters(const WebUChar* characters, size_t numCharacters) = 0;
> 
> the indentation here looks to be wrong.

Fixed.

>> WebCore/platform/graphics/chromium/FontCacheLinux.cpp:61
>> +    icu::Locale locale = icu::Locale::getDefault();
> 
> If this is for Linux then is the best way to get the locale? In zygote_main_linux.cc we preload the ICU timezone information, but I don't see anything about locale. So, if ICU tries to access the disk for this then it'll fail.

This doesn't hit the disk.

In the chrome side of the patch, I explicitly set for each renderer the default ICU locale from
commandline option passed from browser process (--lang=xx).  getDefault() returns the value set then.

On Chrome OS, zygote and sandbox helper are spawned off of main browser process in very early stage,
where the browser process does not know about UI language at that point.  After user logs in,
the browser changes its UI language according to the user's pref, and then passes '--lang='
commandline option and this is the only knowledge that renderers know.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.