[Webkit-unassigned] [Bug 25533] Elements on the same line should be treated as such by caret navigation

Tue Mar 1 21:46:14 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=25533

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84236|review?                     |review-
               Flag|                            |

--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org>  2011-03-01 21:46:14 PST ---
(From update of attachment 84236)
View in context: https://bugs.webkit.org/attachment.cgi?id=84236&action=review

> Source/WebCore/ChangeLog:28
> +        (WebCore::createCommandMap): Add the new commands needed for the
> +        GTK port, related with up/down movement in caret browsing mode.

I don't think it's correct to fix just GTK port.  This is a bug that needs to be fixed on all ports regardless of whether the caret navigation is enabled or not.  To demonstrate the bug on other ports, simply enable the design mode on the attached test case.

> Source/WebCore/editing/EditorCommand.cpp:620
> +static bool isVerticallyCoincident(VisiblePosition origin, VisiblePosition candidate, int originX, SelectionDirection direction)
> +{

This is definitely not right.  We shouldn't be adding these selection related code in EditorCommand.cpp, which is supposed to be delegating all the work to the rest of editing code.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.